ga4gh / tool-registry-service-schemas

APIs for discovering genomics tools, their metadata and their containers
Apache License 2.0
30 stars 18 forks source link

Tool description sourced from tool version can involve guesswork #244

Open denis-yuen opened 1 year ago

denis-yuen commented 1 year ago

Tools have a description https://github.com/ga4gh/tool-registry-service-schemas/blob/v2.0.1/openapi/openapi.yaml#L552-L560

Tools have a version specific description queued up https://github.com/ga4gh/tool-registry-service-schemas/commit/1dd4bf806f98fa2e3d224d1976f6179de5cd46d6

This may be implementation specific but could be a common issue. In Dockstore, the tool-level description is sourced from a default version of the tool that has been picked to "present" to end-users, kind of like the default branch feature in GitHub. However this version is not indicated to end users in TRS. This can lead to broken links in the description since the description may have relative links to other workflows

An example is https://dockstore.org/api/ga4gh/trs/v2/tools/%23workflow%2Fgithub.com%2FPacificBiosciences%2Fwdl-humanwgs%2Fwdl-humanwgs

Possible solutions:

TRS-related:

┆Issue is synchronized with this Jira Story ┆Project Name: Zzz-ARCHIVE GA4GH tool-registry-service ┆Issue Number: TRS-68

denis-yuen commented 1 year ago

Another possible solution is to present a path as an additional property for a tool for which to resolve the relative path links

uniqueg commented 1 year ago
  1. I can see a default version being useful, especially if SemVer is not followed by the tool.
  2. Better documentation is often a good idea, or always, if it's really better :)