search

ga4gh / va-spec

An information model for representing variant annotations.
Apache License 2.0
17 stars 4 forks source link

Feedback on Annotation-Statement cardinality #1

Open mbrush opened 6 years ago

mbrush commented 6 years ago

In general, hoping folks will review and provide feedback on the Annotation Content Model (ACM) outlined here.

In particular, review the recent additions about 'primary' vs 'secondary' statements, and there being only one primary statement per annotation.

Input welcome in this ticket, or using comments on the ACM google doc itself, concerning: (A) whether the concepts, terms, and distinctions made in the ACM are clear, intuitive, and pragmatic, and (B) what implications that these conceptual / terminological decisions may have for our data model.

Steven-N-Hart commented 6 years ago

I am a little concerned about when a secondary statement conflicts with the primary. For example, this variant has conflicting annotations in ClinVar. Can we provide an explicit example of how this should be represented?