ga4gh / vrs-python

GA4GH Variation Representation Python Implementation
https://github.com/ga4gh/vrs
Apache License 2.0
51 stars 27 forks source link

Replace vrs models with pydantic generated models #194

Closed larrybabb closed 1 year ago

larrybabb commented 1 year ago

Use the vrs 2.0 alpha schema for this...

  1. Replace pythonjsonschemaobjects tool in core by using https://github.com/koxudaxi/datamodel-code-generator/ to generate the pydantic classes which can be manually modified (for the short term).
    • use the generator to bootstrap the generation of classes and manually update and add them to vrs-python
    • NOTE: we may be concerned about continuing to use the generator after we bootstrap for fear of having to deal with keeping the manual updates in sync. We DO want to keep in alignment with Pydantic's approach because other tools are somewhat reliable on this and it may help with our future LinkML upgrade in the future.
theferrit32 commented 1 year ago

Taking some notes on what needs to be done to the input/output of datamodel-codegen:

theferrit32 commented 1 year ago

@toneillbroad

theferrit32 commented 1 year ago

closing as completed as a work in progress in the 2-alpha branch