Move CnvTranslator _from_hgvs to Hgvs Tools

ga4gh / vrs-python

GA4GH Variation Representation Python Implementation

https://github.com/ga4gh/vrs

Apache License 2.0

51 stars 27 forks source link

Move CnvTranslator _from_hgvs to Hgvs Tools #392

Closed korikuzma closed 7 months ago

korikuzma commented 7 months ago

I think I would prefer that all the code that is related to these hgvs classes be moved to the hgvs-tools.py module. That was my aim with the prior refactoring work (which was half baked but had good intentions). Could you consider moving this (or posting a new issue for the future to refactor out the hgvs-specific logic from Translator.pyinto hgvs-tools.py?

_Originally posted by @larrybabb in https://github.com/ga4gh/vrs-python/pull/387#discussion_r1559861244_

korikuzma commented 7 months ago

This actually could've been done in #387 but I wasn't thinking properly

korikuzma commented 7 months ago

This was done in #393