search

ga4gh / vrs-python

GA4GH Variation Representation Python Implementation
https://github.com/ga4gh/vrs
Apache License 2.0
51 stars 27 forks source link

feat: VRS 1.3 digests may be computed for Alleles and Sequence Locations #427

Closed ahwagner closed 4 months ago

ahwagner commented 4 months ago

Note: tests only pass for Python 3.12 due to changes in f-string implementation introduced in 3.12. These should be addressed before merge.

closes #382

ahwagner commented 4 months ago

Some docstrings / comments would be nice

Added in 06bc1b5. And 2e55240.

ahwagner commented 4 months ago

@korikuzma I agree with your recommended changes and left comments on each. However, for the purpose of the ASHG demo this is good enough and I am going to merge. Would you kindly take on implementing the above as follow-up PRs?

korikuzma commented 4 months ago

@korikuzma I agree with your recommended changes and left comments on each. However, for the purpose of the ASHG demo this is good enough and I am going to merge. Would you kindly take on implementing the above as follow-up PRs?

@ahwagner what's the priority for this?

ahwagner commented 4 months ago

Medium-to-low priority: I would like to see these improvements implemented by the end of August.

korikuzma commented 4 months ago

@ahwagner Made PR for this. #431 . Supporting other VRS versions will be separate issue.