search

ga4gh / vrs-python

GA4GH Variation Representation Python Implementation
https://github.com/ga4gh/vrs
Apache License 2.0
51 stars 27 forks source link

sync with root-inheritance-fix from VRS #441

Closed larrybabb closed 3 months ago

larrybabb commented 3 months ago

removed reference to VRS ValueObject which was removed in VRS branch root-inheritance-fix PR under review.

@korikuzma please check my work and convert let me know how to get this completed and released.

larrybabb commented 3 months ago

@korikuzma I need some pointers on how to update the pypi stuff (I think) so that the notebooks can be updated to address the fix to the efo: -> EFO: PR that was made to vrs 2.x recently. I'd like to know how to do that if you have the time to show me.

korikuzma commented 3 months ago

@larrybabb Since we no longer use python jsonschema objects, we have to manually update the source code in VRS-Python. For the notebooks, there are some hard-coded EFOs which would also need to be updated manually.

korikuzma commented 3 months ago

@larrybabb why was EFO case changed to lowercase in this commit? https://github.com/ga4gh/vrs/commit/cafe826954488a314c73c6e145c3c3e230bb6151