search

ga4gh / vrs

Extensible specification for representing and uniquely identifying biological sequence variation
https://vrs.ga4gh.org
Apache License 2.0
78 stars 32 forks source link

Revise CytobandLocation in schema diagram #343

Open ahwagner opened 2 years ago

ahwagner commented 2 years ago

From manuscript reviewer comments:

Figure 2 (and the diagram in https://vrs.ga4gh.org/en/1.2/schema.html#overview): I see SimpleInterval has been moved down to the deprecated section of vrs.yaml so perhaps it should be omitted? More importantly, CytobandInterval has "integer" as the type of start and end. I think that should be "string" for simplicity. (I see in vrs.yaml that the actual type of start and end is HumanCytoband, but that's just string with a regex spec, no need to clutter up the diagram with that.) CytobandInterval is also missing "+ type: string", making it look like the odd one out in the General Purpose Types panel, but from vrs.yaml it looks like it does include type ("CytobandInterval").

github-actions[bot] commented 6 months ago

This issue was marked stale due to inactivity.