search

ga4gh / vrs

Extensible specification for representing and uniquely identifying biological sequence variation
https://vrs.ga4gh.org
Apache License 2.0
80 stars 34 forks source link

Copy Number Count text and json example do not match #437

Closed korikuzma closed 9 months ago

korikuzma commented 1 year ago

https://github.com/ga4gh/vrs/blob/c4595ae173e10195e6a7157364a6edb5a7276283/docs/source/terms_and_model.rst?plain=1#L388-L407

If we want to keep the json, we should update the text to 3 or more copies of APOE.

If we want to keep the text, the json should be:

    {
      "copies": {
        "type": "DefiniteRange",
        "min": 2,
        "max": 4
      },
      "subject": {
        "gene_id": "ncbigene:672",
        "type": "Gene"
      },
      "type": "CopyNumberCount"
    }
sivangbagri commented 11 months ago

Hii I would like to work on this issue , please assign @korikuzma

korikuzma commented 11 months ago

@sivangbagri go for it

sivangbagri commented 11 months ago

@korikuzma hii I have made the PR , kindly review