ga4gh / vrs

Extensible specification for representing and uniquely identifying biological sequence variation
https://vrs.ga4gh.org
Apache License 2.0
80 stars 32 forks source link

Inherit vrs from domain entity #507

Closed larrybabb closed 3 months ago

larrybabb commented 3 months ago

change VRS ValueObject to inherit from DomainEntity instead of Entity

ahwagner commented 1 month ago

🤔 I wonder if there are examples where we would use mappings in VRS? Expressions allow for creating string-based representations in different syntaxes, and it seems like the notion of a concept map directly contrasts with the notion of a value object. Maybe we moved too quickly on this.