search

ga4gh / vrsatile

VRS Added Tools for Interoperable Loquacious Exchange
Apache License 2.0
0 stars 2 forks source link

transition to value_id and value inheritance #16

Open ahwagner opened 3 years ago

ahwagner commented 3 years ago

Currently, we have descriptors with specific field names for value objects, e.g. variation_id and variation in VariationDescriptor. We should consider reverting to value_id and value defined in the ValueObjectDescriptor and inherited by all descendent classes.

ahwagner commented 2 years ago

We have gone back and forth on whether we have specific fields (e.g. variation, disease_id) for corresponding descriptors, or just the same generic slot (value, value_id). Bringing this issue back to the top since it was an active discussion point today.

This may be informed by discussion and decisions on #34.