search

ga4gh / vrsatile

VRS Added Tools for Interoperable Loquacious Exchange
Apache License 2.0
0 stars 2 forks source link

Add a location descriptor attribute to gene descriptors #18

Open ahwagner opened 2 years ago

ahwagner commented 2 years ago

@larrybabb REALLY wants this

sumit-158 commented 2 years ago

Hey, @ahwagner Is anyone is working on this! if not can I work on this?? Ans also can you help me to out how to start??

ahwagner commented 2 years ago

Please do! We use GitHub flow for development. This is a great issue for an introduction to adding to VRSATILE.

The Descriptor classes are all maintained in https://github.com/ga4gh/vrsatile/blob/main/schema/vod-source.yaml. We have not transferred over Gene and Location Descriptors from the documentation yet; follow the template in that YAML to add the YAML representation in the Gene and Location descriptors per their current information models here. Also, I would add both Gene Descriptor and Location Descriptor to the oneOf array here when making those changes.

sumit-158 commented 2 years ago

@ahwagner Did I have to change "vodjson" file also?

sumit-158 commented 2 years ago

@ahwagner is there any problem in this pull request! why no one have review it yet?

ahwagner commented 2 years ago

@ahwagner Did I have to change "vodjson" file also?

yes; please see the PR for instructions on building the YAML / JSON / .rst artifacts from source.