ga4gh / workflow-execution-service-schemas

The WES API is a standard way to run and manage portable workflows.
Apache License 2.0
82 stars 38 forks source link

Remove Definition and Reference Python Code #189

Closed patmagee closed 1 year ago

patmagee commented 1 year ago

The swagger definition of WES has been deprecated in favor of openapi 3.0, however it was kept in the repo for backwards compatibility. Speaking with a number of people at plenary it came up that instead of being helpful, this has actually caused some issues among implementors. Since the swagger API is outdated it can easily lead to implementing the "WRONG" api. Additionally (I have felt this as well), there is no clear direction of what spec doc should be modified when implementing a PR leading to implementors editing both docs.

Additionally, I have removed the Reference python code. This code used to be built as part of the travis build process, but has been commented out for sometime and is outdated with the current spec. This has also been superseded by the WES GA4GH starter kit (https://github.com/ga4gh/ga4gh-starter-kit-wes), which is more actively maintained and updated.

patmagee commented 1 year ago

@jaeddy @wleepang I apologize, it looks like local state from a divergent develop branch sneaked its way in. I have updated the PR to remove those extra files, if you to take one additional view

uniqueg commented 1 year ago

Yes - finally!! 😆