Closed patmagee closed 1 year ago
I've just seen that I noticed the issue with RunStatus
vs State
before and that it should be fixed with #172 (I will look at that tomorrow). So please ignore that part. I guess it's just important that we merge #172 first and then merge that into this PR before merging.
Given the timeline for connect and the previous sign off by @wleepang and @uniqueg I am going to go ahead an merge this into develop
What
This PR is an implementation of the discussion in #204.
TaskLog
which is distinct from theLog
model. The rational here is that having a specific model for task information allows us to put more task oriented data in it. Properties likeid
andtes_uri
are strictly related to tasks, sincerun_id
already is defined in the outer scope of a workflow.task_logs
within theRunLog
asArray[Log]
to prevent any breaking change.id
MUST be required if we are try rely on it for addressing tasks. Requiring this within theLog
attribute did not make sense since it was shared between the workflow and individual tasks. Additionally, forcing a required attribute could break downstream implementationstes_uri
field to allow for interop between tes and wes. This approach does not try to incorperate TES into the WES sep directly but provides an easy and Official mechanism to go between the two. TES is a much more rich view of a task so we should not try to re-implementsystem_logs
properties toLog
andTaskLog
entities.Closes #204