ga4gh / workflow-execution-service-schemas

The WES API is a standard way to run and manage portable workflows.
Apache License 2.0
82 stars 38 forks source link

feat: add alternative schema for array items in RunListResponse #207

Closed uniqueg closed 1 year ago

uniqueg commented 1 year ago

Alternative to #172 Closes #165

This PR differs from #172 in the following ways:

Taken together, this proposal avoids or partly addresses the following concerns raised against #172:

It does NOT address the concern that "clients may not agree with selection of fields".

uniqueg commented 1 year ago

Thanks @patmagee :) I would still like to prepare a PR for the solution proposed here, before reaching out to implementers to vote. But I'm afraid it's gonna take me another two weeks or so.

patmagee commented 1 year ago

@uniqueg can you please rebase this on develop

patmagee commented 1 year ago

@wleepang @cjllanwarne I wonder what your thoughts are on this modified PR?

wleepang commented 1 year ago

I think tags is more important than name for this response. (see my comment above).

From a client perspective, runid, (start|end)_time, and status are certainly must haves. I'd say tags is required and it is strongly recommended that "run_name" and "workflow_name" tags are included.

uniqueg commented 1 year ago

I think tags is more important than name for this response. (see my comment above).

From a client perspective, runid, (start|end)_time, and status are certainly must haves. I'd say tags is required and it is strongly recommended that "run_name" and "workflow_name" tags are included.

I'm with you. It seems to me like we all agree and it's mostly a semantic argument. The main point is that we want to encourage implementers as much as possible to make this info available, without making their life unduly hard if, for whatever reason, they can't. So let it be in tags :)

patmagee commented 1 year ago

@uniqueg once you update this PR to remove name and make fields like start_time and end_time optional, I will go ahead and merge it!

uniqueg commented 1 year ago

@uniqueg once you update this PR to remove name and make fields like start_time and end_time optional, I will go ahead and merge it!

Done