ga526321 / prat

Automatically exported from code.google.com/p/prat
GNU General Public License v3.0
0 stars 0 forks source link

PopupMessage: using nicknames consisting of one or more uppercase letters fails #127

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What version of Prat are you using?
r57072

Do you use embedded libraries or standalones?
Standalones

What language/realm type?
German RP realm, using enGB client.

What steps will reproduce the problem?
1. Add a nickname with an uppercase letter, for example, "Lenni"
2. Have someone say that word in chat doesn't trigger the expected popup
3. Using "lenni" works fine

What is the expected output? What do you see instead?
A popup should be seen when someone uses the entered nickname in any case.
No popup is seen instead.

Please provide any additional information below.
The "bug" can be found in Prat_PopupMessage:CheckText. The loop for
iterating the nicknames does this:

  for k, v in pairs(self.db.profile.nickname) do
    local nicknameL = v

This assumes, the user entered a nickname entirely in lowercase letters. To
fix it, you could use

    local nicknameL = strin.lower(safestr(v))

for example.

Original issue reported on code.google.com by Tawer...@gmail.com on 21 Dec 2007 at 5:19