search

gaalcaras / academic

Jekyll theme with a focus on simplicity, typography and flexibility
MIT License
88 stars 89 forks source link

Hamburger Menu Broken on Mobile Safari #9

Open kerim opened 3 years ago

kerim commented 3 years ago

Thanks for this lovely theme. I'm adapting it for my own use and discovered that the hamburger navigation menu on mobile safari (I can't test Android) does not work. The menu collapses to the hamburger, but tapping it does not do anything. This is true, for instance, with your own personal site: https://gaalcaras.com/fr/

kerim commented 3 years ago

I figured this one out. In _includes/header.html you need to change line 13 from:

<span class="menu-icon">

to

<span class="menu-icon" onclick="">

kerim commented 3 years ago

I've created a pull request for this. First time I've done that on Github, so I hope I did it correctly.