search

gaalcaras / ncm-R

R autocompletion for Neovim and vim 8 :memo: :bar_chart: :zap:
GNU General Public License v3.0
115 stars 10 forks source link

Deoplete source #10

Open petobens opened 6 years ago

petobens commented 6 years ago

Do you plan to implement (or do you happen to know if there is) a deoplete source for r completion? Thanks!

kxzk commented 6 years ago

Definitely would be nice, especially considering nvim-completion-manager is no longer maintained.

mschilli87 commented 6 years ago

Just cross-referencing the relevant issues to avoid the same discussion everywhere:

The second was actually mentioned in the first: https://github.com/jalvesaq/Nvim-R/issues/326#issuecomment-386109839

The whole discussion started here: https://github.com/jalvesaq/Nvim-R/issues/326#issuecomment-385804953

And the maintainance situation was already mentioned here: https://github.com/jalvesaq/Nvim-R/issues/326#issuecomment-387163852

gaalcaras commented 5 years ago

Hi there,

Unfortunately, I had to put ncm-R on the back burner for a while, mainly because I had to switch from R to Python for work, so I rarely used ncm-R myself anymore.

The good news is, I temporarily had to work on a R project last week, and not having proper R completion was... frustrating! So I'm back at it now.

My priority has been to update ncm-R to make it work with ncm2. I'm keeping that on a feature branch for now. Would you mind trying it and telling me if it works for you? If that's the case I'll merge it to the main branch. Please give your feedback in #13.

Now, to your point about deoplete. NCM is pretty cool and hackable, but the abrupt deprecation of ncm in favor of ncm2 obviously broke ncm-R for a while, since I didn't have time to maintain it and to look into ncm2. So I have been thinking about supporting another completion framework. That would allow ncm-R to work even if ncm2 breaks again in the future. Deoplete is obviously larger than ncm-R, but I don't use it myself. I have no idea whether it's actually more stable than ncm2 or whether Shougo sometimes introduces breaking changes. I also don't have a lot of time to study if supporting deoplete will require a lot of work or maintenance, if I should just start something else from scratch to work with Nvim-R and deoplete, or if I should look into some other completion framework.

I could use your input on these topics! What do you think?

gaalcaras commented 5 years ago

FIY, I just merged the feature branch into master, you should use that instead of the now deleted feature branch.

petobens commented 5 years ago

Maybe @Shougo can suggest some way of porting the ncm2 source into deoplete, personally I have no idea how easy/difficult that might be...

Shougo commented 5 years ago

Hm... Current deoplete source interface is pretty simple. You can read the code in deoplete.

Deoplete is obviously larger than ncm-R, but I don't use it myself. I have no idea whether it's actually more stable than ncm2 or whether Shougo sometimes introduces breaking changes.

I keep the compatibility if possible. It is not guaranteed though.

khughitt commented 5 years ago

@Shougo Any suggestions for examples of other custom sources of a similar nature that one might use as a template / to get some insights into interfacing with deoplete?

Shougo commented 5 years ago

You should read deoplete source code before asking me...

https://github.com/Shougo/deoplete.nvim/blob/master/rplugin/python3/deoplete/source/around.py

khughitt commented 5 years ago

Fair enough. I likely won't have time to take a stab at this at least until Fall, but perhaps if no one else has implemented this source by then, I'll take a stab at it.