gaasedelen / tenet

A Trace Explorer for Reverse Engineers
MIT License
1.31k stars 133 forks source link

Bug Report: get_instruction_addresses returning 0 instructions #21

Open AntoineBlaud opened 1 year ago

AntoineBlaud commented 1 year ago

Hello,

Thank you for creating such great plugins. I have identified a small issue with the Tenet plugin that I would like to address. Specifically, I noticed that the get_instruction_addresses function returns zero instructions when running certain programs, such as /bin/ls. After debugging, I determined that this issue comes from the code snippet that drops data segments, as shown below:

if seg.sclass != ida_segment.SEG_CODE:
    continue

Although I was able to resolve the issue by removing this code, doing so may slow down the loading of traces. I would like to explore alternative solutions to this problem to ensure optimal performance of the plugin while still preserving its functionality.

J-jaeyoung commented 1 year ago

I resolved the issue by changing that code to the following,

- if seg.sclass != ida_segment.SEG_CODE:
+ if seg.sclass != ida_segment.SEG_CODE and seg.sclass != ida_segment.SEG_DATA
...