search

gaasher / I-JEPA

Implementation of I-JEPA from "Self-Supervised Learning from Images with a Joint-Embedding Predictive Architecture"
MIT License
249 stars 24 forks source link

Using all patches instead of target patches to filter the context block. #5

Closed jhairgallardo closed 1 year ago

jhairgallardo commented 1 year ago

Hello! I have a question in the forward function of the IJEPA_base class. I see that in line 154 (https://github.com/gaasher/I-JEPA/blob/main/model.py#L154) you are using all_patches as input in the get_context_block function for the argument target_patches. Shouldn't the input to that argument be the target_patches variable instead? (obtained from the get_target_block function here https://github.com/gaasher/I-JEPA/blob/main/model.py#L150)

Thank you

Edit: I realized the all_patches does not actually mean all the patches, but instead it means all the target patches. I am closing this issue.