search

gab-ai-inc / gab-dissenter-extension

Dissenter.com Browser Extension source code
https://dissenter.com
Apache License 2.0
272 stars 43 forks source link

[Firefox] YouTube videos don't get comment pages connected correctly when video contains URL data after v=xxxxxxxx #43

Closed optoisolated closed 5 years ago

optoisolated commented 5 years ago

YouTube videos don't get comment pages connected correctly when video contains URL data after the video Identifier.

Example URL: https://www.youtube.com/watch?v=xxxxxxxxxxx&feature=push-prem-sub&attr_tag=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

Noted when viewing a Premiere video.

mgabdev commented 5 years ago

Hi @optoisolated thank you for submitting an issue. This is expected behavior. (Nearly all) Query parameters on urls designate a brand new url. For example, on youtube all video urls contain a ?v=xxxxxxxxx. Any additional parameters (such as feature=... or tag=...) create an entirely new comment page on dissenter.

The reason for this is that it would be difficult to differentiate or associate a page by ignoring some query parameters while others are key to that url.

When I said "nearly all" above, we do actually ignore/remove certain query parameters such as the utm tags.

A solution to this issue would be to remove the additional query parameters feature=... and attr=... in order to have the standard url structure that youtube videos resolve to: https://www.youtube.com/watch?v=xxxxxxxxxxx