search

gab-ai-inc / gab-dissenter-extension

Dissenter.com Browser Extension source code
https://dissenter.com
Apache License 2.0
272 stars 43 forks source link

[Edge] Login button redirects to regular tab, does not authenticate for popup #7

Open coldacid opened 5 years ago

coldacid commented 5 years ago

What I Did

  1. Click Dissenter extension button next to address bar
  2. Click "Log In" button in Dissenter popup window
  3. Log in in new tab opened up
  4. Click Dissenter extension button again to re-open popup

What I Expected

What I Got

Browser, OS, and Extension Info

mgabdev commented 5 years ago

@coldacid thanks for submitting an issue. This is expected behavior. The reason for this is when attempting to log into Gab using the Gab.com API via Dissenter.com through the extension, it is not secure and it cannot perform the OAuth redirect as the extension is simply an iFrame of https://dissenter.com.

Does the extension properly work after logging in via the newly created tab as you described?

coldacid commented 5 years ago

@mgabdev no, that's what I'm saying. After logging in, I still just get the login page in the popup, and there's no sign of Dissenter itself on any of my other tabs.

mgabdev commented 5 years ago

@coldacid Are you still experiencing this issue with the latest release of r9? https://github.com/gab-ai-inc/gab-dissenter-extension/releases/tag/r9

coldacid commented 5 years ago

@mgabdev let me set it up and I'll tell you.

coldacid commented 5 years ago

Yep, still experiencing it unfortunately.

marknoble commented 3 years ago

Still seeing this in the r12 release. I was logged into Gab, but clicking the Dissenter extension results in a window with a spinner.

The DevTools Console shows the following error:

Uncaught ReferenceError: browser is not defined
    at Popup.e.init (popup.js:4)
    at HTMLDocument.<anonymous> (popup.js:4)

Dissenter Screenshot 2021-02-16 191123

marknoble commented 3 years ago

@mgabdev I just tested the change in my PR and with the spinner issue fixed in Edge (Chromium) users can now navigate to https://dissenter.com/ and log-in, then the Dissenter plugin works in Edge.

Dissenter working Screenshot 2021-02-16 195751

It's a workaround, but a very low-impact one that makes the plugin quite usable on Edge now.