search

gabe565 / CastSponsorSkip

⏭️ Skip YouTube ads and sponsorships on all local Google Cast devices
Apache License 2.0
286 stars 6 forks source link

Feature Request: Build for armv6 #10

Closed schumi4 closed 11 months ago

schumi4 commented 11 months ago

Hi,

I've been using nichobi/sponsorblockcast on an old RPi B without problems. After installing through apt I receive Illegal Operation on starting CastSponsorSkip.

Is providing a build vor armv6 possible? Thanks in advance!

gabe565 commented 11 months ago

That should be possible! Let me add an armv6 target and see if the build passes.

gabe565 commented 11 months ago

Frustratingly, it seems like Debian groups together armv6 and armv7 devices and calls them both armhf. I could disable the armv7 build, but it runs faster on devices that support it so I'd rather keep it if possible. I may need to push armv6 builds to a separate package. I might call it castsponsorskip-armv6?

gabe565 commented 11 months ago

Alright I went ahead and replaced armv7 with armv6 for now. Can you test?

schumi4 commented 11 months ago

Works beautifully! 5-10% CPU usage compared to 70-80% with SponsorBlockCast!

Edit: It sadly does not skip skippable ads, they don't show up in log either. Should I create a new issue?

gabe565 commented 11 months ago

Amazing!

Sure, if you don't mind creating an issue then I might need your help with testing. I have YouTube Premium and haven't been able to test the ad skip, even though I was pretty sure it would work.