gabe565 / CastSponsorSkip

⏭️ Skip YouTube ads and sponsorships on all local Google Cast devices
Apache License 2.0
286 stars 6 forks source link

feat: Add SkipDelay to delay skipping a segment #19

Closed jvpernis closed 10 months ago

jvpernis commented 10 months ago

Hi there! Thanks for this awesome project. This is actually my first encounter with SponsorBlock, and I actually like it a lot!

However, I found the sponsor segment timing to be very agressive, to the extent that I'd get thrown off guard when it skips. I don't mind watching the first few seconds of a segue, as it actually even helps me mentally prepare for the skip.

Therefore, I added the --skip-delay flag to delay skipping at the start of a segment. Let me know what you think!

gabe565 commented 10 months ago

Thank you, this is a great idea! PR looks good, but could you update the flag documentation by running:

go run ./internal/generate/docs

Also, this doesn't block a merge, but maybe change the shell completion values to something smaller like "500ms", "1s", "2s"?

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jvpernis commented 10 months ago

Done, and done!

gabe565 commented 10 months ago

Amazing. Thank you!