search

gabe565 / CastSponsorSkip

⏭️ Skip YouTube ads and sponsorships on all local Google Cast devices
Apache License 2.0
286 stars 6 forks source link

Using the mute feature but not SponsorBlock is difficult and sucks. #42

Closed squeakyneb closed 8 months ago

squeakyneb commented 8 months ago

I want to use the ad muting and skipping features of this tool, but I don't want to use SponsorBlock. Many of the channels I watch actually do very funny sponsor segments and I enjoy them.

The obvious option seemed to be setting env var CSS_CATEGORIES. CSS_CATEGORIES='' gives me default behaviour (the thing I don't want). So does CSS_CATEGORIES=' '. I had to really fool the config system with CSS_CATEGORIES=' , ' to get it to just have an empty list of zero categories.

This is a pretty rough user experience. Variables explicitly set as being empty should be interpreted as empty, not as unset. It's not the same.

gabe565 commented 8 months ago

@squeakyneb I agree that empty envs aren't the same as unset values, and that it should be possible to disable the SponsorBlock while keeping ad skip, but I also want to mention that loading these values from envs is handled by a package and not by me, so it must be desired behavior for a lot of projects.

Let me decide the best way to implement this. Should be a pretty quick thing to add. In the mean time, the fact that CSS_CATEGORIES=' , ' works is hilarious.

gabe565 commented 8 months ago

@squeakyneb I'm releasing v0.6.0 which lets you set CSS_SKIP_SPONSORS=false to disable sponsor skip.