Added tests, updated deps, added LICENSE file, other general updates

gabefromutah / gatsby-plugin-facebook-pixel

Gatsby plugin to add facebook pixel onto a site

15 stars 21 forks source link

Open AustinLeeGordon opened 4 years ago

AustinLeeGordon commented 4 years ago

Wanted to bring this plugin up to date a little bit. Changes made in this PR:

Added Jest testing
Switched to Gatsby's babel config for plugins
Added a pixelId check
Added peer dependencies
Added a prepublishOnly script so the latest changes are built whenever publishing to npm
Added a LICENSE file

Let me know if you have questions about any of the changes!

gabefromutah commented 3 years ago

Wow. Completely missed this by an entire year. My apologies. Can we double-check the work and get this merged in once and for all?

gabefromutah commented 3 years ago

Made some changes on my own but would still love to bring in your work, especially around testing. Could you update the PR? Thanks

AustinLeeGordon commented 3 years ago

Wow. Completely missed this by an entire year. My apologies. Can we double-check the work and get this merged in once and for all?

@gabefromutah No worries!

Made some changes on my own but would still love to bring in your work, especially around testing. Could you update the PR? Thanks

@gabefromutah Okay, I'll see what I can do. Thanks!

gabefromutah commented 3 years ago

@AustinLeeGordon care to give this another try?