search

gabek / node-internet-radio

Node.js module to get Now Playing information from an internet radio stream.
MIT License
49 stars 19 forks source link

Update lodash due to a security alert #6

Closed gabek closed 6 years ago

gabek commented 6 years ago

The version of lodash used in this project is being marked as a security alert on Github. We need to update it and test the library with the new version.

screen shot 2018-10-19 at 5 12 16 pm
parthi82 commented 6 years ago

I will take this

gabek commented 6 years ago

@parthi82 Awesome, thanks!

parthi82 commented 6 years ago

@gabek created a pull request with updated version of lodash. but the only thing this project uses is _.compact which can be replace with native ".filter()" function so we could remove the lodash dependency.

gabek commented 6 years ago

@parthi82 That's even better! If you want to pull lodash out and just use filter instead then that's a win.

parthi82 commented 6 years ago

@gabek updated the PR

abumalick commented 5 years ago

Can you publish the last version on npm @gabek ?

The security warning is present with 0.1.5

gabek commented 5 years ago

Yes! I'll get that out in the next day or so.

gabek commented 5 years ago

Done!

abumalick commented 5 years ago

Thank you very much