search

gabergg / react-scrollable-anchor

Smooth scrolling anchors bound to URL hash
MIT License
291 stars 89 forks source link

Does total rerender for route with react-router custom history when scrolling sections #48

Open tchock opened 6 years ago

tchock commented 6 years ago

What I do: I am using a custom history (but still using the browser history) in react-router and scroll through sections.

What I see: It re-mounts the route component because react-router handles this as a complete route change causing jumping to the top of the page.

What I expect: The hash should change, but the route should not be re-rendered.

Possible solution: passing a custom hash update function to the ScrollableAnchor component that will handle the hash change in a custom matter (using the history prop that react-router provides).

moritzmock commented 4 years ago

@tchock I have the same problem as you, so I hope someone (@gabergg , @bjacobel, @Marcel-G, @savtwo) can check this pull request!

Thank you in advance mmock