search

gabesmed / ember-leaflet

Ember + Leaflet = Fun with maps
gabesmed.github.io/ember-leaflet
MIT License
164 stars 35 forks source link

Ember.beforeObserver is deprecated #123

Closed miguelcobain closed 9 years ago

miguelcobain commented 9 years ago

DEPRECATION: Ember.beforeObserver is deprecated and will be removed in the near future. See http://emberjs.com/deprecations/v1.x/#toc_beforeobserver for more details.

Awem commented 9 years ago

I don't receive these deprecation warnings on latest Ember CLI (#122 neither). When do they occur?

miguelcobain commented 9 years ago

@AW-UC Both deprecations show up in my Ember 1.13.5.

Which version are you running?

Awem commented 9 years ago

Ok, then you are apparently using Ember CLI master. I am using the latest release (1.13.1) which is still on Ember 1.13.3. No deprecations there, yet.

miguelcobain commented 9 years ago

You don't need to use ember-cli master to use other versions of ember.

Just change ember version on bower.json.

bobbysciacchitano commented 9 years ago

I get the deprecation warning running Ember 1.13.8 with the same version of Ember-Cli.

The message is: DEPRECATION: Ember.beforeObserver is deprecated and will be removed in the near future. See http://emberjs.com/deprecations/v1.x/#toc_beforeobserver for more details.

Specifically affects layers/collection.js _contentWillChange.

tostercx commented 9 years ago

Removed in ember 2.

floqqi commented 9 years ago

@gabesmed or @miguelcobain: Any plans for Ember 2.0? Meanwhile it would be nice if there could be a message that 2.0 is currently not supported.

pedrokost commented 9 years ago

+1

gabesmed commented 9 years ago

taking a first pass at fixing this in https://github.com/gabesmed/ember-leaflet/pull/134 -- could use some help testing in practice as i'm worried about breaking peoples' implementations

gabesmed commented 9 years ago

please test me!!

ianpetzer commented 9 years ago

@gabesmed Awesome work! Thanks.

I can confirm that this is working for me on Ember 1.13.9 ... Ie: All of my ember-leaflet maps are working as expected and the .beforeObserver deprecation warnings are gone.

pedrokost commented 9 years ago

@gabesmed It is working fine for me as well on Ember 1.13.10. Thank you!

floqqi commented 9 years ago

@gabesmed Works for me using Ember 2.1. Thanks!