search

gabesoft / evil-mc

Multiple cursors implementation for evil-mode
MIT License
383 stars 35 forks source link

Use a keymap #100

Closed Silex closed 4 years ago

Silex commented 4 years ago

This change is pretty obvious, but it also raises questions about the other bindings that don't start with gr and consistency.

I feel that binding C-n C-p etc is kinda invasive... those could also be on the gr prefix, e.g g r C-n etc.

Silex commented 4 years ago

Rebased.

duianto commented 4 years ago

This change broke evil-mc: error: (wrong-type-argument listp evil-mc-make-all-cursors) on load #106

Silex commented 4 years ago

Oops, sorry :sweat:

I missed the dolist (key-data keys) loop, I didn't return the map from the let form...

duianto commented 4 years ago

It happens.

Investigate how the error occurred, maybe you had some local configurations that hid the startup warning. Or it might not have been tested thoroughly.

Try to find what the issue was, fix it and resubmit a working PR.

Just learn from it and keep moving forward. 😄