search

gabime / spdlog

Fast C++ logging library.
Other
24.29k stars 4.54k forks source link

Integer constant overflow #2607

Closed albert-github closed 1 year ago

albert-github commented 1 year ago

https://github.com/gabime/spdlog/blob/f29f369a12c701db27e816c6762e914863e8e951/include/spdlog/fmt/bundled/format-inl.h#L1153-L1154

Won't this overflow, I got on Windows, 32-bit, some warnings about it:

...\deps\spdlog\include\spdlog\fmt\bundled\format-inl.h(1154): warning C4307: '*': integral constant overflow
...\deps\spdlog\include\spdlog\fmt\bundled\format-inl.h(1186): warning C4307: '*': integral constant overflow
..\deps\spdlog\include\spdlog\fmt\bundled\format-inl.h(1207): warning C4307: '*': integral constant overflow
gabime commented 1 year ago

This code is part of fmtlib. Please re open the issue there

albert-github commented 1 year ago

Created issue for it:https://github.com/fmtlib/fmt/issues/3274

albert-github commented 1 year ago

The issue https://github.com/fmtlib/fmt/issues/3274 has been fixed