search

gablab / realtime

0 stars 2 forks source link

Subj moved logic #16

Closed sasen closed 11 years ago

sasen commented 11 years ago

oh my gosh. the button logic. it is done. @akeshavan, please bang on it, and let's talk about what breaks. i haven't merged in any of the other pull requests yet... i'll be working on that tomorrow.

sasen commented 11 years ago

known issues: (1) i don't have the new layout (with comments form/modal) merged in yet, so moved=True is hardcoded right now. (2) there is a tiny bit of logic for that modal that i need to talk to @akeshavan about (to make sure that subjectMoved can only be true on a visit that is not complete and has already been started). (3) there is a tiny bug that i believe is low-priority, and might not even matter with the real comments modal. namely, it's possible to make the functional scan buttons go disabled while they say "End Foo". it's not a real problem--merely confusing to the user--because when the "End Foo" button gets activated, you can click it and it'll let you "Start Foo" again, since enough TRs won't have been collected. point is, there are no more processhandle errors, so it could only confuse the user and add extra timestamps to the button history.

EDIT [11/26/2012 16:56 EDT]: all of the above issues are still issues. i have verified and accepted all PRs except dummylaunch, so this PR is now current with gablab/master, and should still be easy to test. Please let me know if you have any feedback on this PR! In the meantime, I'm going to work on handmerging dummylaunch in.