gabm / Satty

Satty - Modern Screenshot Annotation. A tool inspired by Swappy and Flameshot.
Mozilla Public License 2.0
388 stars 18 forks source link

Generate completions and CI/CD #24

Closed TD-Sky closed 7 months ago

TD-Sky commented 7 months ago

Changes

References

Release assets: https://github.com/TD-Sky/Satty/releases/tag/v0.8.0 Actions: https://github.com/TD-Sky/Satty/actions

Notes

  1. You may not need Makefile anymore.
  2. PKGBUILD should be rewritten.
  3. I include the files which are suitable for publishing to crates.io even though satty isn't publish so far.
TD-Sky commented 7 months ago

Test was over.

gabm commented 7 months ago

wow thank you, what a great contribution :tada:

does this also install and package the icon the .desktop file?

TD-Sky commented 7 months ago

wow thank you, what a great contribution 🎉

does this also install and package the icon the .desktop file?

It doesn't actually do installation instead it packs the things what installation needs.

gabm commented 7 months ago

okay cool.. that's what i meant... a tarball with all the sources and assets ..

gabm commented 7 months ago

@TD-Sky there seems to be an error with the release pipeline?! https://github.com/gabm/Satty/actions/runs/7113283418/job/19364916436

TD-Sky commented 7 months ago

Have you retried running action?

gabm commented 7 months ago

I can do that but it says 403 .. so I guess a token is missing or something?

gabm commented 7 months ago

I guess something from here? https://github.com/softprops/action-gh-release#permissions

TD-Sky commented 7 months ago

Have you turned on CI/CD write permission in repo settings?

gabm commented 7 months ago

no.. it seems that also can/needs to be requested as part of the workflow?

permissions:
  contents: write
gabm commented 7 months ago

https://github.com/gabm/Satty/pull/32

TD-Sky commented 7 months ago

I don't think so. I never write that when I met write permission problem and just turned on the setting.

gabm commented 7 months ago

okay.. I think that turns it on for all jobs. I'd prefer having it in the workflow file

gabm commented 7 months ago

works after #32