gabm / Satty

Satty - Modern Screenshot Annotation. A tool inspired by Swappy and Flameshot.
Mozilla Public License 2.0
486 stars 22 forks source link

feat: draft freehand highlighter #77

Closed DerpDays closed 3 months ago

DerpDays commented 5 months ago

This is will add a freehand highlighter as the default (with shift to align it), and then have a selection highlight (like there currently is) accessible by pressing ctrl whilst on the highlighter, since this was suggested at some point (though since currently the highlighter tool is the selection it might make more sense to make the freehand one accessible through ctrl instead), currently this is just draft and needs quite a bit of cleanup.

EDIT: kept the block/selection highlighter as the default, with the freehand/line highlighter being the alternative highlighter, this is configurable via the CLI or config.

00-kat commented 4 months ago

though since currently the highlighter tool is the selection it might make more sense to make the freehand one accessible through ctrl instead

I think (not a dev, just a random user) that it should probably be an option you can set in the config file.

DerpDays commented 4 months ago

yeah that's probably best, i'll get to working on this in a few days so it can finally not be a draft

gabm commented 4 months ago

I agree.. I didn't have a look at the PR, @DerpDays let me know if I can help

DerpDays commented 4 months ago

Sorry for the large delay & also the large commit (this should have been broken down into quite a few more commits).

This should mostly ready, here's an overview of the new things:

Let me know if there's anything that needs changing or can be done better.

00-kat commented 4 months ago

If you start holding shift mid-way should it draw a straight line from the beginning or from the spot you started holding shift from (it does latter rn)?

DerpDays commented 4 months ago

The spot you started holding shift from, thought it'd give more options for how people want to draw it, since you can just hold shift when starting the highlight to achieve the other effect

gabm commented 4 months ago

I just tested it, it looks great!

gabm commented 3 months ago

Thank you for this great contribution :partying_face: