Rework tag parsing - Githubissues

gabor-boros / minutes

Sync worklogs between multiple time trackers, invoicing, and bookkeeping software.

https://gabor-boros.github.io/minutes/

MIT License

27 stars 2 forks source link

Rework tag parsing #36

Closed gabor-boros closed 2 years ago

gabor-boros commented 2 years ago

Description

This PR refactors the way of tag parsing works and removes not needed arguments.

Supporting information

The tag parsing configuration was too verbose and did not add any extra value. By simplifying the tag parsing it is easier to maintain.

Dependencies

N/A

Screenshots

N/A

Testing instructions

Run minutes as without the remove config option

Other information

This PR unifies the empty regex checking as well.

Checklist

[x] Documentation is updated
[x] Pull request is rebased onto main
[x] Commit history is clean

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 09a19968 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	2

The test coverage on the diff in this pull request is 95.6% (75% is the threshold).

This pull request will bring the total coverage in the repository to 74.8% (2.0% change).

View more on Code Climate.