gaborcsardi / secret

:closed_lock_with_key: Secure sharing of sensitive information in R packages
Other
102 stars 16 forks source link

Support for ed25519 encryption #48

Open yogat3ch opened 2 years ago

yogat3ch commented 2 years ago

A PR that will add ed25519 encryption support.

gaborcsardi commented 2 years ago

Great, thanks! So we do not need to change anything else? E.g. for the decryption part?

Btw. can you please add an entry to NEWS.md mentioning this PR and your username? Thanks again!

yogat3ch commented 2 years ago

So we do not need to change anything else? E.g. for the decryption part?

Btw. can you please add an entry to NEWS.md mentioning this PR and your username? Thanks again!

We do need quite a bit more to make sure the encryption works, and then the decryption function has to be detected too. I'm a bit lost on the encryption/decryption workflow and am not sure where to go from here. We could either meet via Zoom or if you think it would be easier to implement yourself that could work as well. Do you have a preference @gaborcsardi?

gaborcsardi commented 2 years ago

Thanks, I'll try to take a look at it soon.