search

gabordemooij / redbean

ORM layer that creates models, config and database on the fly
https://www.redbeanphp.com
2.31k stars 280 forks source link

Phpstan Complains about missing type CustomModel #953

Open mattimatti opened 2 weeks ago

mattimatti commented 2 weeks ago

Hello

While overriding SimpleFacadeBeanHelper::getModelForBean

I'm wandering if the type CustomModel is needed.

https://github.com/gabordemooij/redbean/blob/1bb7b5b93031d1a458a503ee91b595c8f7a8c83d/RedBeanPHP/BeanHelper.php#L57

https://github.com/gabordemooij/redbean/blob/1bb7b5b93031d1a458a503ee91b595c8f7a8c83d/RedBeanPHP/BeanHelper/SimpleFacadeBeanHelper.php#L93

gabordemooij commented 2 weeks ago

CustomModel was meant as a marker interface, but it's not used I think. I removed it. https://github.com/gabordemooij/redbean/pull/954