search

gaborsimon / WeatherStation

This project is intended to provide a self-made, basic weather station based on ATMEL AVR microcontroller and HD44780 LCD display.
MIT License
0 stars 0 forks source link

utils macro bug #1

Closed gaborsimon closed 8 years ago

gaborsimon commented 8 years ago

File: utils.h Problematic macro: #define BIT_GET(reg,bit) ((reg) & (1u << (bit)))

The macro has to return with TRUE or FALSE. Shift operation is missing, so in this case the macro cannot return with 1 or 0.