search

gabotaco / rc-website-web

1 stars 6 forks source link

Fix "jobsEmojiList" not defined #71

Closed joaomeuputo closed 2 years ago

joaomeuputo commented 2 years ago

Moved "customEmojiFolder" variable from map.js to icons.js, since icons.js loads first, and requires the variable to be defined to initialize the jobs list array.

gabotaco commented 2 years ago

Icons.js loads first sometimes

There's a race condition that we've had difficulty fixing that's associated with this error

gabotaco commented 2 years ago

Here's the associated issue https://github.com/rhit-corridg/rc-website-web/issues/3

joaomeuputo commented 2 years ago

Welp. I didn't really explore the project, just saw that happen and made a pull req. Couldn't this be used as a temp fix then? Since you have other plans to fix this issue.

Cheers

gabotaco commented 2 years ago

No problem. We can merge it and see if the frequency of the error goes down. We're actually looking for someone to help out with this issue if you're interested in taking a closer look at it

joaomeuputo commented 2 years ago

Sure. I just need to find out how to run the whole project on localhost 🙂