search

gabotechs / graphqxl

GraphQXL is a new language built on top of the GraphQL syntax that extends the original language with some additional features useful for creating scalable and big server side schemas. This repository contains the source code for the GraphQXL compiler.
https://gabotechs.github.io/graphqxl
MIT License
272 stars 8 forks source link

Preserve function argument comments #57

Closed RobertVillalba closed 6 months ago

RobertVillalba commented 6 months ago

It seems that functions (queries/mutations) with comments for their arguments get converted into functions with the right arguments but no comments.

type Query {
  "Get all the things"
  getThings(
    "Some filter"
    filter: String
  ): [Thing!]!
}

becomes

type Query {
  "Get all the things"
  getThings(filter: String): [Thing!]!
}

Could we preserve the argument documentation?

gabotechs commented 6 months ago

yeah, this totally makes sense, and it's actually very easy to implement, I'll prepare a quick PR now

gabotechs commented 6 months ago

Released in v0.40.2, feel free to reopen if you find any issue

RobertVillalba commented 6 months ago

Awesome I can verify this works! Thank you!