Switch to Sonar API 6.7

gabrie-allaigre / sonar-gitlab-plugin

Add to each commit GitLab in a global commentary on the new anomalies added by this commit and add comment lines of modified files

GNU Lesser General Public License v3.0

713 stars 207 forks source link

Switch to Sonar API 6.7 #109

Closed ghost closed 6 years ago

ghost commented 6 years ago

Migrate to Sonar API from 6.7.

Version 6.7 (from 5.6)
HttpException requires content parameter (added response content)
Use MapSettings in unit tests
Update tests to check that body is passed to the exception message

N.B! Breaks backward compatibility with 5.6. API in main stream is already able to communicate with 6.7 branch feature.

ghost commented 6 years ago

Accidentally closed the PR when mirroring changes from upstream.

ghost commented 6 years ago

I will check what is wrong with the build.

lucaspouzac commented 6 years ago

Hi @gabrie-allaigre, could you include this PR in your future release ?

ghost commented 6 years ago

@lucaspouzac We have switched in our plugin to 6.7 though this is not absolutely necessary. I was new to gitlab API so I just switched to 6.7 to get access to the branch parameter. Though it can be also done in a way that @gabrie-allaigre did: take generic request and provide parameters via generic API instead of dedicated method.

gabrie-allaigre commented 6 years ago

Hi, Go to the 6.7 API is not enough, we must also replace all deprecated methods. I will soon accept this PR for the next version. Thanks

gabrie-allaigre commented 6 years ago

Hi, I will take pieces of your PR. Because I'm going to make a version for the SQ 7.0 API.

ghost commented 6 years ago

@gabrie-allaigre I am Ok with that. I can rebase the changes or redo them.

ghost commented 6 years ago

@gabrie-allaigre I have already started locally to switch from deprecated API to their replacements in 6.x.

gabrie-allaigre commented 6 years ago

@ap-edubrovka I just pushed a new version with the SC API 7.0 I miss the ProjectBuilder class

degree commented 6 years ago

@gabrie-allaigre I have checked the changes and looks like I did almost exactly the same changes (renamed settings to configuration in one place). I approached ProjectBuilder once but have nothing to share on this. I have to get myself familiar with SQ API first to understand how we can replace it. (ap-edubrovka is also my account, degree is private).