search

gabrie-allaigre / sonar-gitlab-plugin

Add to each commit GitLab in a global commentary on the new anomalies added by this commit and add comment lines of modified files
GNU Lesser General Public License v3.0
713 stars 207 forks source link

SonarQube 7.6 Marketplace Missing GitLab Plugin #222

Open jonnygrm opened 5 years ago

jonnygrm commented 5 years ago

Hi, I noticed that our fresh install of SonarQube 7.6 does not have GitLab as an available option in the marketplace menu. The only GitLab related plugin displaying is GitLab Auth. Is this a comparability issue? Thanks Jonny

vlandemaine-orange commented 5 years ago

Hi,

I have the same issues, no Gitlab plugin in a fresh install of SonarQube 7.6, and also on SonarQube 7.7..

Thanks

marcolindner commented 5 years ago

Hi, same here. Only GitLab Auth Plugin available in Marketplace. Thanks Marco

gabrie-allaigre commented 5 years ago

Hello,

Sorry I no longer use SonarQube for several months. I received a message from SonarQube 1 year ago, they will integrate in their BranchPlugin GitLab (as for Github) And it really discouraged me to continue. I will not do any more evolution on the plugin. I have more time to spend. Following the evolutions of Sonar and GitLab take too much time.

Thank you

ghost commented 5 years ago

Hi Gabriel !

Thanks a lot for your work on this plugin. If you don't plan any futur evolution on the plugin will you release the 4.0.1 version ? (currently SNAPSHOT).

dmarin commented 5 years ago

Hi @gabrie-allaigre, maybe you could do a handover? I would not mind to review the current issues and merge them if appropriate, and pretty sure others would also offer their help. IMO this is a great tool, and I would love to keep updating it from sonar itself

dominikmontada commented 5 years ago

@gabrie-allaigre I also would love to see a handover happen. As long as Sonar has not released an official version of this tool, we definitely need this.

DanielRuf commented 5 years ago

Hi @gabrie-allaigre, maybe you could do a handover? I would not mind to review the current issues and merge them if appropriate, and pretty sure others would also offer their help. IMO this is a great tool, and I would love to keep updating it from sonar itself

Either this or we should mark this repo here as deprecated / unmaintained, create an org account for this and invite contributors and maintainers to keep this project alive.

dmpe commented 5 years ago

Hi @gabrie-allaigre, This project ^ your plugin is way too much important to become unmaintained. The community is ready to step up and I would help as well. Please let us all work on this project together.

alephtwo commented 5 years ago

I have a team that would be willing to help keep this up to date as well - we make active use of this plugin for automated code review, and it's a core part of our workflows. In recent weeks we've explored building our own version of it, but in my opinion that work would be better put towards helping the broader community maintain this one.

dmarin commented 5 years ago

I created this ticket on sonar --> https://community.sonarsource.com/t/support-gitlab-plugin-for-sonarqube/8193?u=david_marin To be fair I would rather keep the plugin under @gabrie-allaigre if possible since he did the hard work :) but the "community" sounds good to me too :)

alexander-frolov commented 5 years ago

But is it really possible to keep this plugin alive? SonarQube 7.7 dropped the sonar.analysis.mode parameter (https://docs.sonarqube.org/latest/setup/upgrade-notes/), which this plugin relies on, and I'm not sure if there is a replacement for that. Instead, SonarSource suggests moving to a commercial Developer edition that includes a Pull Request Analysis feature (https://docs.sonarqube.org/latest/analysis/pull-request/) but that does not support GitLab. They deprecated the GitHub plugin for the same reason (https://docs.sonarqube.org/display/PLUG/GitHub+Plugin). I wish there is a replacement for the sonar.analysis.mode parameter but not sure if there really is.

dominikmontada commented 5 years ago

@alexander-frolov As far as I am aware you don't need the analysis parameter, at least when running the developer version, since it supports branch analysis. That is exactly what we were doing: we just ran a branch/merge request analysis and didn't use the sonar.analysis.mode parameter.

But you do raise a good point, as I'm not sure what people running the community edition can do about this.

alephtwo commented 5 years ago

The developer edition is quite expensive for us, so we've been relying on a few workarounds to get the functionality. The loss of the sonar.analysis.mode parameter has been a long time coming, but it's still a huge blow. If it's gone, then it really does call into question whether or not maintaining this plugin is feasible long term.

gabrie-allaigre commented 5 years ago

Hello, That's what I'm going to do:

Voilà.

I can not give a date, I put myself back in it. I will try to do it quickly.

jairbubbles commented 5 years ago

@alexander-frolov The sadest part in this is that they won't support GitLab officially any time soon :-(

https://community.sonarsource.com/t/merge-requests-support-for-gitlab/806/12

jakub-bochenski commented 5 years ago

New version 5.0.0, remove all code for preview mode. And add compatibilty for SonarQube >=7.7

@gabrie-allaigre could you share some hints on how do you intend to support MRs with 7.7+? The good guys maintaining a similar Stash Sonar Plugin don't see a way to handle this: https://github.com/AmadeusITGroup/sonar-stash/issues/202#issuecomment-500195455

t-8ch commented 5 years ago

(Maintainer of the mentioned sonar-stash plugin)

If there is an easy way of supporting this feature with new SQ I am indeed interested. If it requires major rework it may make sense to do it in a way that it can be used with both Gitlab and Bitbucket.

(Personally I would not be involved for that, but hopefully somebody would step up)

carlspring commented 5 years ago

Hi,

What do you guys think of my comment here? Would it make sense to create a core project that does the analysis and then simply add "providers" for it to enable it to publish the results to the respective provider implementation (Stash, Gitlab, Github, etc)?

Perhaps we could join up and come up with a solution to the problem both projects are having?

lbammes commented 5 years ago

@gabrie-allaigre - Wanted to see how things are going with the 5.x plugin as we have updated to version 7.9 and would like to determine if we can utilize the plugin at some point. If not we may look at other alternatives for usage of API's, etc.

stalb commented 5 years ago

On SonarQube developer edition, they don't need the preview mode because branch analysis is enabled.
So removing preview mode is a way to pull users to a commercial version.

SonarQube andGilab have also conflicting business models: Gitlab tries to convince users to stay inside Gitlab and to give up external services. In consequence neither of Gitlab or SonarQue is willing to put resources to help developing a plugin...

However there is still a community branch plugin for SonarQube. Using it would allow to remove the need of the preview mode.
If I do so, will the Sonar GitLab Plugin work with 7.7+ versions of SonarQube ?

shouldnotappearcalm commented 4 years ago

Is there any way to support sonarqube 8.2 community edition?