search

gabrie-allaigre / sonar-gitlab-plugin

Add to each commit GitLab in a global commentary on the new anomalies added by this commit and add comment lines of modified files
GNU Lesser General Public License v3.0
712 stars 207 forks source link

Findings are not unresolved discussions #259

Open lealoureiro opened 4 years ago

lealoureiro commented 4 years ago

Hello,

First of all thank you for support in developing this plugin.

At moment I'm trying to use version 4.0.0 of the plugin with this options: -Dsonar.gitlab.ci_merge_request_iid=$MERGE_REQUEST_ID -Dsonar.gitlab.merge_request_discussion=true but this discussions are attached to diff but not appearing as unresolved blocking the Merge Request...

Is this expected behaviour ? I would expect to appear as unresolved like the ones created by peer reviews.

Thanks in advance!

Regards, Leandro

drampelt commented 4 years ago

I just got this working for a project, it looks like the MR discussion feature (https://github.com/gabrie-allaigre/sonar-gitlab-plugin/pull/216) was merged in after the latest release, so I had to download and compile a new version of this plugin for it to work.