search

gabrie-allaigre / sonar-gitlab-plugin

Add to each commit GitLab in a global commentary on the new anomalies added by this commit and add comment lines of modified files
GNU Lesser General Public License v3.0
712 stars 207 forks source link

Inconsistency between README and code regarding sonar.gitlab.quality_gate_fail_mode #263

Open p3k opened 4 years ago

p3k commented 4 years ago

In the README it says (please note the case):

sonar.gitlab.quality_gate_fail_mode | Quality gate fail mode: error, warn or none (default error)

https://github.com/gabrie-allaigre/sonar-gitlab-plugin/blob/ff206e19c301fc63e6e77cec14ca30e5a77d966b/README.md#L336

…while in the Java code the properties are handled uppercase:

https://github.com/gabrie-allaigre/sonar-gitlab-plugin/blob/5d3033c3c56c316e7686ab9eeeb1d7ad6c0e4875/src/main/java/com/talanlabs/sonar/plugins/gitlab/models/QualityGateFailMode.java#L24

At least it becomes obvious that setting sonar.gitlab.quality_gate_fail_mode=none does not change anything while sonar.gitlab.quality_gate_fail_mode=NONE does.