search

gabriel-dehan / chronicondb-client

Chronicon (ARPG) item and skills database (React 17)
https://chronicondb.com
11 stars 4 forks source link

Some percentages not being represented as percentages in skills.json #2

Open iconmaster5326 opened 3 years ago

iconmaster5326 commented 3 years ago

Some percentages, values of proc mostly, are not represented as percentages in skills.json. Here is an example of what I mean:

image

The 3000 there should probably be 30%.

gabriel-dehan commented 3 years ago

Thanks for the report, that's very interesting, indeed some floats must be represented as integers and I definitely didn't notice it!

gabriel-dehan commented 3 years ago

@iconmaster5326 I'll have to find the rule about this because Squarebits isn't sure himself, I'll try to whip up something and see if I can update the skills parser to reflect that (instead of doing it in the view) so you can benefit from it too.

By the way did you manage to understand everything about the templating? It was a bit convoluted so if you have any questions don't hesitate :)

iconmaster5326 commented 3 years ago

I haven't found a template that I've misparsed yet, so I think I'm good on that front. Please do tell me when you've updated skills.json. Thanks!