search

gabrielStanovsky / unified-factuality

Code, data and models for the paper "Integrating Deep Linguistic Features in Factuality Prediction over Unified Datasets" (Stanovsky, Eckle-Kohler, Puzikov, Dagan and Gurevych ACL 2017)
MIT License
7 stars 0 forks source link

spaCy is not mentioned in the Pre-requsities, but step 9 assumes that it is one. #16

Closed ypuzikov closed 7 years ago

ypuzikov commented 7 years ago

It says:

spaCy with English models

However, the command is given only for loading models.

gabrielStanovsky commented 7 years ago

Right, I meant to run that after the user installs spaCy, I tried clarifying that by writing "after spaCy is installed". I don't want to give instructions on how to install each of these, just to provide a way to download the models after you have the package installed. Do you think that this could be made clearer somehow?

judithek commented 7 years ago

I found the installation instructions on the spacy site super easy to follow

gabrielStanovsky commented 7 years ago

So you think we can drop that additional line about downloading the English model?

ypuzikov commented 7 years ago

Yes, I think so. Or put them together:

pip install spacy python -m spacy download en

gabrielStanovsky commented 7 years ago

Done