search

gabrielStanovsky / unified-factuality

Code, data and models for the paper "Integrating Deep Linguistic Features in Factuality Prediction over Unified Datasets" (Stanovsky, Eckle-Kohler, Puzikov, Dagan and Gurevych ACL 2017)
MIT License
7 stars 0 forks source link

Proofreading of the online demo #17

Closed gabrielStanovsky closed 7 years ago

gabrielStanovsky commented 7 years ago

@judithek @ypuzikov The online demo is live at: http://u.cs.biu.ac.il/~stanovg/factuality.html I also added a link from the readme to it.

What do you think? Can you help with proof-reading the introductory texts in the demo? Feel free to change anything directly at factuality.html.

You won't see your changes appear immediately in the online webpage, as I need to first deploy it to my university webpage.

Thanks!

ypuzikov commented 7 years ago

I think everything is fine, but not sure about the font size of the example. I would make it bigger, if you agree. Also, "Language" does not have any value -- is this intended?

gabrielStanovsky commented 7 years ago

Sure, feel free to change the font size. Language shouldn't be there, it's leftovers from the PropS online demo

judithek commented 7 years ago

it might be helpful for users if we include other sample sentences - what do you think? e.g. I tried "Don comvinced Peter to pay his taxes" which nicely shows the contrast refuse - convince

judithek commented 7 years ago

otherwise the demo looks fine, and I agree to Yevgeniy's comments

gabrielStanovsky commented 7 years ago

I removed the language part, and added an examples section, these are links which call our demo with that sentence.

@ypuzikov , you mean the font in brat?

ypuzikov commented 7 years ago

Yes. Or could be in the style.css file also -- I do not know exactly how to do that, 'factuality.html' does not have any font settings.

ypuzikov commented 7 years ago

Currently, the fonts for 'Unified Factuality Annotator - Online Demo', 'Download', 'Online Demo' are much bigger than the rest of the text. I would propose to increase the size of the font for the rest of the text by 2 or 3 pt.

gabrielStanovsky commented 7 years ago

I changed the fonts, and added the css files to the repo. Is that too big now? (I really don't have a good eye for this :))

Still need to find out how to change font conveniently in brat.

judithek commented 7 years ago

I like the bigger font size, also looks good on an iphone

judithek commented 7 years ago

on a smart phone the links "Online Demo" and "Download" in the header menue do not point to something meaningful (only Publications does)

gabrielStanovsky commented 7 years ago

This actually works on mine (Android). Maybe this depends on screen size? Maybe if you scroll all the way down, and then try the download link it'll work?

judithek commented 7 years ago

this isn't important I think - the demo page is compact and all the info can be found without navigation as well I also did not find an explanation for this in the code, so maybe we leave it as is

ypuzikov commented 7 years ago

I like the adjusted font size. Is it possible to have the same font in the submission and output boxes as well?

gabrielStanovsky commented 7 years ago

I managed to get the same size in the submission box, but not in the output. Couldn't get brat to conform using its CSS files :(

gabrielStanovsky commented 7 years ago

Moved remaining size issue to #18