./src/scripts/install_annotator.sh: unzip problems

[ypuzikov]

When running "unzip -f props.zip", I get this:

Archive: props.zip 67e91f834d00bf282c654f6be661a7cd6e909566

As you can see, the archive files do not get extracted and the pipeline defined in "./scripts/install_annotator.sh" breaks. Running just "unzip props.zip" works without problems.

OS: x86_64 Ubuntu 16.04.1 LTS (xenial) Kernel: 4.4.0-75-generic

[gabrielStanovsky]

@ypuzikov I'm not sure what's the error log here, does the folder get extracted under a different folder name? Does the command only lists some checksum of the file? Some other error?

I used the -f (freshen) flag to avoid error in cases where the props folder already exists:

-f     freshen existing files, i.e., extract only those files that already exist on disk and that are newer than the disk copies.

[ypuzikov]

I agree, this is strange -- I also checked the manual entry for unzip and was quite surprised that -f option does not work as intended on my machine. Here is the full log:

[sudo] password:

Installing PropS... --2017-05-16 09:17:51-- https://github.com/gabrielStanovsky/props/archive/master.zip Resolving github.com (github.com)... 192.30.253.113, 192.30.253.112 Connecting to github.com (github.com)|192.30.253.113|:443... connected. HTTP request sent, awaiting response... 302 Found Location: https://codeload.github.com/gabrielStanovsky/props/zip/master [following] --2017-05-16 09:17:51-- https://codeload.github.com/gabrielStanovsky/props/zip/master Resolving codeload.github.com (codeload.github.com)... 192.30.253.120, 192.30.253.121 Connecting to codeload.github.com (codeload.github.com)|192.30.253.120|:443... connected. HTTP request sent, awaiting response... 200 OK Length: unspecified [application/zip] Saving to: ‘props.zip’

props.zip [ <=> ] 202.38K 510KB/s in 0.4s

2017-05-16 09:17:52 (510 KB/s) - ‘props.zip’ saved [207235]

Archive: props.zip 67e91f834d00bf282c654f6be661a7cd6e909566 ~/tmp/unified-factuality/src/props-master ~/tmp/unified-factuality/src python: can't open file 'setup.py': [Errno 2] No such file or directory

[gabrielStanovsky]

Is it possible that it unzips the folder under that weird name:

67e91f834d00bf282c654f6be661a7cd6e909566

[ypuzikov]

No, I do not have such folders. And I do not have "props-master" folder either.

[gabrielStanovsky]

Can you try running just the unzip command separately and report if it gets unzipped?

unzip -f props.zip

Can you try achieving the desired functionality (unzip and no error when the folder exists) with some other flag combination on your machine?

[ypuzikov]

I think it should be -u option, not -f. From the manual:

-f freshen existing files, create none -u update files, create if necessary

The files from the zip archive are not extracted, because -f option does not create new files in the destination folder, only updates them if they are present. I tried adding -u and it worked.

[judithek]

for me ./src/scripts/install_annotator.sh runs smoothly without error messages

testing on Ubuntu 14.04.5 LTS Release: 14.04 Codename: trusty Python 2.7.6 (default, Jun 22 2015, 17:58:13) [GCC 4.8.2] on linux2

[ypuzikov]

@judithek , @gabrielStanovsky , can you re-run the script with the -u option insted of -f? For me only -u option works.

[gabrielStanovsky]

Works for me, changed in the repo to -u. @judithek Let me know if we can close this.

[judithek]

strangely, I could not reproduce the fully smooth behavior.

the script only runs with sudo -E and outputs at the end when finishing the following messages:

Successfully installed numpy packaging pyparsing requests webencodings pysocks CherryPy cheroot portend tempora Cleaning up... /usr/bin/python: cannot import name IncompleteRead; 'spacy' is a package and cannot be directly executed

[judithek]

but I did not get any unzip problems so this issue can be closed