search

gabrielStanovsky / unified-factuality

Code, data and models for the paper "Integrating Deep Linguistic Features in Factuality Prediction over Unified Datasets" (Stanovsky, Eckle-Kohler, Puzikov, Dagan and Gurevych ACL 2017)
MIT License
7 stars 0 forks source link

sudo -E when running ./src/scripts/install_annotator.sh #4

Closed ypuzikov closed 7 years ago

ypuzikov commented 7 years ago

The users might oppose to using sudo privileges. If we absolutely have to use it, maybe it is better to include a description of what is going to be installed in the README file?

gabrielStanovsky commented 7 years ago

@ypuzikov Not sure how to go about this, I include the python requirements file, and install PropS, TruthTeller is included. Is there anything else you'd add?

I can actually just drop the sudo from the instructions. The users might then get permission errors, and decide to add sudo on their own. This happens to me a lot when installing libraries. What do you think?

ypuzikov commented 7 years ago

You are probably right. At the very least, I would add the mention about installing python-setuptools and pip (see #3).

ypuzikov commented 7 years ago

By the way, a side-product of running this command with sudo is the inability to delete files created by the script without sudo.

ypuzikov commented 7 years ago

I believe we cannot do much about this. Closing the issue.

gabrielStanovsky commented 7 years ago

Keeping open to make sure I remember to edit readme :)

gabrielStanovsky commented 7 years ago

Fixed readme. Closing