gabrielbrunop / haxball-server

A small server utility for Haxball
20 stars 4 forks source link

remove `http_access allow all` #8

Closed jakjus closed 2 years ago

jakjus commented 2 years ago

hey, http_access allow all line in squid.conf makes the host being used by millions of bots after it is getting scanned as an open proxy. you can see these connections in squid logs (/var/log/squid/access.log). it may downgrade the server performance.

on top of that, such configuration is forbidden by majority of server providers (and can get you banned without refund).

not using this line still works fine in my personal setup (using firefox selenium runner), but should work for every other runner - like puppeteer - as well.

gabrielbrunop commented 2 years ago

I tested it here and you're right. I'll merge the pull request, thank you.