gabrielbull / php-ups-api

PHP Wrapper for all UPS API
MIT License
456 stars 255 forks source link

Add LabelLinksIndicator to LabelDelivery for ShipmentServiceOption #331

Open pista7 opened 2 years ago

pista7 commented 2 years ago

Hi again!

At work, we realized what could be a small error. For ShipmentServiceOptions, the node expects a LabelLinksIndicator instead of the LabelLinkIndicator (note the 's'), in contrast with the LabelRecoveryRequest which indeed expects the LabelLinkIndicator, without the 's'.

The result was that the URL was not returned in the accept response.

To fix that, we added an option to set LabelLinksIndicator modifying as well the relevant if statement for ShipmentServiceOptions.

Again, let me know if I need to do something else in order to have it merged.

Cheers! X.